-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] change js engine #15747
Conversation
license check failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15747 +/- ##
============================================
- Coverage 39.11% 39.08% -0.03%
+ Complexity 4856 4851 -5
============================================
Files 1316 1316
Lines 44970 44964 -6
Branches 4811 4809 -2
============================================
- Hits 17588 17574 -14
- Misses 25481 25491 +10
+ Partials 1901 1899 -2 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
It seems the
nashorn-sandbox
is a better solution to avoid some security in js engine, see https://github.com/javadelight/delight-nashorn-sandbox.Brief change log
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java
Verify this pull request